dianfu commented on a change in pull request #13930:
URL: https://github.com/apache/flink/pull/13930#discussion_r518492438
##########
File path: flink-end-to-end-tests/test-scripts/test_pyflink.sh
##########
@@ -272,8 +272,6 @@ if [[ "${EXPECTED_MSG[*]}" != "${SORTED_READ_MSG[*]}" ]];
then
exit 1
fi
-stop_cluster
-
Review comment:
You're right. I find that the root case of this problem is that the
"PyFlink YARN per-job test" in this script will cleanup the _on_exit_commands
and so test_clean_up will never be called.
The calling path is as following:
```
|---start_hadoop_cluster_and_prepare_flink
|--- source "$(dirname "$0")"/common.sh
|--- source "${TEST_INFRA_DIR}/common_utils.sh"
|--- _on_exit_commands=()
```
Will update the PR to split the "PyFlink YARN per-job test" into a separate
script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
