gaoyunhaii commented on pull request #13956: URL: https://github.com/apache/flink/pull/13956#issuecomment-723001217
Yes, currently the logic diverge a lot. However, there are still some utility methods get used by both cases, like the `BucketAssigner`, method to check result, etc.. Do you think it would made sense if we have an `AbstractFileSinkITCase` that contains the common parts and have two different IT Cases for blocking mode and streaming mode? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
