[
https://issues.apache.org/jira/browse/FLINK-19802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227644#comment-17227644
]
Steven Zhen Wu commented on FLINK-19802:
----------------------------------------
[~sewen][~lzljs3620320] to make the `BulkFormat` truly generic and reusable by
Iceberg source, can we avoid `SplitT` extending from `FileSourceSplit`? just
leaves it as pure generic type `SplitT`. I think `IcebergSourceSplit` shouldn't
extend from `FileSourceSplit` , because it contains many fields not meaningful
for IcebergSourceSplit (e.g. filePath, offset, length etc.). Iceberg already
captured those info in its data structure.
> Let BulkFormat createReader and restoreReader methods accept Splits directly
> ----------------------------------------------------------------------------
>
> Key: FLINK-19802
> URL: https://issues.apache.org/jira/browse/FLINK-19802
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / FileSystem
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Major
> Fix For: 1.12.0
>
>
> To support sources where the splits communicate additional information, the
> BulkFormats should accept a generic split type, instead of path/offset/length
> from the splits directly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
