zhuzhurk commented on a change in pull request #13958:
URL: https://github.com/apache/flink/pull/13958#discussion_r519143747



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java
##########
@@ -91,6 +88,8 @@ public DefaultExecutionTopology(ExecutionGraph graph) {
                this.pipelinedRegionsByVertex = new HashMap<>();
                this.pipelinedRegions = new ArrayList<>();
                initializePipelinedRegions();
+
+               ensureCoLocatedVerticesInSameRegion();

Review comment:
       Yes I agree that publishing `this` in the constructor is not a good idea.
   Will add a separate commit to fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to