aalexandrov edited a comment on pull request #13770:
URL: https://github.com/apache/flink/pull/13770#issuecomment-723341214
@twalthr for the next iteration please check the following two `fixup!`
commits:
- 96c368253be8bcd395ed05f5f99b3f07cbca4f52, which adds support for
non-prefix static keys in `RowDataFieldsKinesisPartitioner`. Test coverage is
added in
-
`RowDataFieldsKinesisPartitionerTest#testGoodPartitionerWithStaticPrefix`,
-
`RowDataFieldsKinesisPartitionerTest#testGoodPartitionerWithStaticSuffix`, and
- `RowDataFieldsKinesisPartitionerTest#testGoodPartitionerWithStaticInfix`.
- c763dced7f725f78ddf9e1c0b83b29d7769b00a5, which reworks option names and
mapping [as discussed in the
GoogleDoc](https://docs.google.com/document/d/1Gchs3gK3nnWyodZMYWyK2q0APRQf1gofsTxKBzwzPLQ/edit?usp=sharing).
- `KinesisOptions#getConsumerProperties` implements the mapping of the
properties for the Table source.
- `KinesisOptions#getProducerProperties` implements the mapping of the
properties for the Table sink.
- Test coverage is added to the happy path tests in
`KinesisDynamicTableFactoryTest`.
### TODOs:
- [ ] Create a follow-up JIRA in oder to add a `KinesisTableITCase`.
- [ ] Create a follow-up JIRA in order to add a
`flink-sql-connector-kinesis` package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
