aalexandrov commented on a change in pull request #13770:
URL: https://github.com/apache/flink/pull/13770#discussion_r519167893
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/utils/JoinedRowData.java
##########
@@ -16,9 +16,16 @@
* limitations under the License.
*/
-package org.apache.flink.table.data;
+package org.apache.flink.table.data.utils;
Review comment:
I don't have a strong opinion as well. My argument of keeping the class
in `org.apache.flink.table.data` was maintaining backwards-compatability, but
based on the established guarantees and expectations this does not seem
essential.
I will add a hotfix commit which adds `hashCode` and `equals` before
changing the package. Feel free to keep or drop the package change commit when
you are merging the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
