StephanEwen commented on a change in pull request #13963:
URL: https://github.com/apache/flink/pull/13963#discussion_r519231464
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/AbstractFileSource.java
##########
@@ -75,12 +75,12 @@
private final FileEnumerator.Provider enumeratorFactory;
- private final FileSplitAssigner.Provider assignerFactory;
+ protected final FileSplitAssigner.Provider assignerFactory;
Review comment:
I have a slight preference to keep these fields `private` and add a
public getter (`public FileSplitAssigner.Provider getAssigner()`.
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/AbstractFileSource.java
##########
@@ -75,12 +75,12 @@
private final FileEnumerator.Provider enumeratorFactory;
- private final FileSplitAssigner.Provider assignerFactory;
+ protected final FileSplitAssigner.Provider assignerFactory;
private final BulkFormat<T, SplitT> readerFormat;
@Nullable
- private final ContinuousEnumerationSettings
continuousEnumerationSettings;
+ protected final ContinuousEnumerationSettings
continuousEnumerationSettings;
Review comment:
Similar as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
