[
https://issues.apache.org/jira/browse/FLINK-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173738#comment-15173738
]
ASF GitHub Bot commented on FLINK-3556:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1749#issuecomment-190722183
Changes look good to me. Good catch @uce :-) +1 for merging.
One minor thing: We check that the configuration contains the
`ZOOKEEPER_RECOVERY_PATH` and then give the configuration to the
`FileSystemBlobStore`. Wouldn't it make more sense to directly pass in the
value of `ZOOKEEPER_RECOVERY_PATH` or do the checking of the correctness of the
value in the `FileSystemBlobStore`? If we pass the configuration, then we don't
actually know, which values will be used internally. This would untie the
`BlobServer` and the `FileSystemBlobStore` a bit.
> Unneeded check in HA blob store configuration
> ---------------------------------------------
>
> Key: FLINK-3556
> URL: https://issues.apache.org/jira/browse/FLINK-3556
> Project: Flink
> Issue Type: Bug
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Priority: Critical
>
> The BlobServer in HA mode checks whether `ConfigConstants.STATE_BACKEND` has
> been configured, which is not needed.
> Remove the check and fail if recovery mode is ZooKeeper and no path has been
> configured.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
