StephanEwen commented on a change in pull request #13776:
URL: https://github.com/apache/flink/pull/13776#discussion_r519436157
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java
##########
@@ -112,7 +111,7 @@ public void accept(Throwable t) {
public abstract void addSplits(List<SplitT> splitsToAdd);
protected void startFetcher(SplitFetcher<E, SplitT> fetcher) {
- executors.submit(new ThrowableCatchingRunnable(errorHandler,
fetcher));
+ executors.submit(fetcher);
Review comment:
But I think @kezhuw has a point - having this in the same class (rather
than in a separat class `ThrowableCatchingRunnable`) is a good if there is a
strict contract between the exception handling and closing. Otherwise the
exception handling is factored out into a separate class
(`ThrowableCatchingRunnable`) but with an implicit contract on how it must be
used, to guarantee the happens-before relationship.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
