tillrohrmann commented on a change in pull request #13982:
URL: https://github.com/apache/flink/pull/13982#discussion_r519673039
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/LeaderRetrievalEventHandler.java
##########
@@ -36,6 +36,8 @@
*
* @param leaderInformation the new leader information to notify {@link
LeaderRetrievalService}. It could be
* {@link LeaderInformation#empty()} if the leader address does not
exist in the external storage.
+ * Duplicated leader change events could happen, so the implementation
should check whether the passed leader
+ * information is truly changed with last stored leader information.
Review comment:
I think this should not go below the `@param` description but the
general description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
