[
https://issues.apache.org/jira/browse/FLINK-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228525#comment-17228525
]
Alexander Alexandrov edited comment on FLINK-20043 at 11/9/20, 11:25 AM:
-------------------------------------------------------------------------
{quote}E.g. I read "Do not relocate guava because it is exposed in the Kinesis
API", this should not apply to a SQL connector because everything is controlled
by us.
{quote}
Just to clarify, you say that in a {{flink-sql-connector-kinesis}} fat jar we
can safely relocate Guava code because the {{FlinkKinesisProducer}} (which is
marked as {{@PublicEvolving}} and depends on some Guava classes) is not meant
to be used directly by {{flink-sql-connector-kinesis}} clients?
{quote}I would make the decision if we need a dedicated
{{flink-sql-connector-kinesis}} module up to the content of the current Kinesis
jar. Does it include Jackson, Guava, JodaTime?
{quote}
Upon manual inspection of the contents of [the
{{flink-connector-kinesis_2.12-1.11.2.jar}} found in Maven
Central|https://search.maven.org/remotecontent?filepath=org/apache/flink/flink-connector-kinesis_2.12/1.11.2/flink-connector-kinesis_2.12-1.11.2.jar]
I cannot find traces of {{jackson}}, {{joda}}, or {{guava}} in the package
contents, so I guess the answer is no.
was (Author: aalexandrov):
{quote}E.g. I read "Do not relocate guava because it is exposed in the Kinesis
API", this should not apply to a SQL connector because everything is controlled
by us.
{quote}
Just to clarify, you say that in a {{flink-sql-connector-kinesis}} fat jar we
can safely relocate Guava code because the {{FlinkKinesisProducer}} (which is
marked as {{@PublicEvolving}} and depends on some Guava classes) is not meant
to be used directly by {{flink-sql-connector-kinesis}} clients?
{quote}I would make the decision if we need a dedicated
{{flink-sql-connector-kinesis}} module up to the content of the current Kinesis
jar. Does it include Jackson, Guava, JodaTime?
{quote}
Upon manual inspection of the contents of [the
{{flink-connector-kinesis_2.12-1.11.2.jar}} found in Maven
Central|https://search.maven.org/remotecontent?filepath=org/apache/flink/flink-connector-kinesis_2.12/1.11.2/flink-connector-kinesis_2.12-1.11.2.jar]
I cannot find traces of {{jackson}}, {{joda}}, or {{guava}} in the package
contents, so I guess the answer is no.
> Add flink-sql-connector-kinesis package
> ---------------------------------------
>
> Key: FLINK-20043
> URL: https://issues.apache.org/jira/browse/FLINK-20043
> Project: Flink
> Issue Type: Improvement
> Reporter: Alexander Alexandrov
> Assignee: Alexander Alexandrov
> Priority: Major
> Attachments: third-party-report.html
>
>
> This is a follow up item after the recent addition of [Kinesis SQL source and
> sink in PR #13770 |https://github.com/apache/flink/pull/13770].
> Create a package that bundles a fat connector jar that can be used by SQL
> clients. See [FLINK-11026|https://issues.apache.org/jira/browse/FLINK-11026]
> and the related PRs for a discussion how to do that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
