StephanEwen commented on a change in pull request #13989:
URL: https://github.com/apache/flink/pull/13989#discussion_r520080247
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/SourceReaderBase.java
##########
@@ -270,7 +270,9 @@ private InputStatus finishedOrAvailableLater() {
splitFetcherManager.checkErrors();
return InputStatus.END_OF_INPUT;
} else {
- throw new IllegalStateException("Called
'finishedOrAvailableLater()' with shut-down fetchers but non-empty queue");
+ // We may fall in this method because of purely
finished splits record. If all splits
Review comment:
Maybe change this to:
> We can reach this case if we just processed all data from the queue and
finished a split, and concurrently the fetcher finished another split, whose
data is then in the queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
