SteNicholas opened a new pull request #14008:
URL: https://github.com/apache/flink/pull/14008


   ## What is the purpose of the change
   
   *`BoundedBlockingSubpartition` may leak network buffer if task is failed or 
canceled. `BoundedBlockingSubpartition` needs to add the close of current 
buffer to recycle the current BufferConsumer when task is failed or canceled.*
   
   ## Brief change log
   
     - *`BoundedBlockingSubpartition#close()` adds the close of the current 
BufferConsumer for recycle to avoid network buffer leakage.*
   
   ## Verifying this change
   
     - *`BoundedBlockingSubpartitionTest` adds 
`testRecycleCurrentBufferOnFailure` test method to verify the test case whether 
to recycle the current BufferConsumer when task is failed or canceled.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to