wuchong commented on a change in pull request #13997:
URL: https://github.com/apache/flink/pull/13997#discussion_r520338895
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java
##########
@@ -318,9 +318,9 @@ public void invoke(RowData value, Context context) throws
Exception {
Row row = (Row) converter.toExternal(value);
assert row != null;
if (rowtimeIndex >= 0) {
- LocalDateTime rowtime = (LocalDateTime)
row.getField(rowtimeIndex);
+ TimestampData rowtime =
TimestampData.fromLocalDateTime((LocalDateTime) row.getField(rowtimeIndex));
Review comment:
```java
// currently, rowtime attribute always
using 3 precision
TimestampData rowtime =
value.getTimestamp(rowtimeIndex, 3);
```
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java
##########
@@ -318,9 +318,9 @@ public void invoke(RowData value, Context context) throws
Exception {
Row row = (Row) converter.toExternal(value);
Review comment:
Remove the `@SuppressWarnings("rawtypes")` annotation on this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
