Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1746#issuecomment-191186632
Hi, @fhueske , i've update the PR based on your comments, except object
reusing in `AggregateGroupCombineFunction`. I found `GroupReduceOperator`
would transform it into `CombineToGroupCombineWrapper` which does not implement
a rich user function. so we can not initiate the reusing object in `open()`. I
think we need add a `RichCombineToGroupCombineWrapper` which used to wrap rich
combinable GroupReduceFunction like 'AggregateGroupCombineFunction'. what do
you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
