AHeise commented on a change in pull request #14024:
URL: https://github.com/apache/flink/pull/14024#discussion_r521147841



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointITCase.java
##########
@@ -531,8 +534,10 @@ public void invoke(Long value, Context context) throws 
Exception {
                        state.numOutput++;
 
                        if (state.completedCheckpoints < minCheckpoints) {
-                               // induce heavy backpressure until enough 
checkpoints have been written
-                               Thread.sleep(0, 100_000);
+                               // induce backpressure until enough checkpoints 
have been written
+                               if (random.nextInt(1000) == 42) {

Review comment:
       Why do we need to reduce the backpressure here? I'm worried that any 
solution on top of it will only work with a certain minimal flow.
   
   Note that in 
https://github.com/apache/flink/pull/13845/commits/ef4f78d9b7bedb10a8c7be3e062032d2e7a0c77c#diff-c0d448d637f04cc203de3592d7fab0ba2412f2d75c59dcf6e44cc4a3c18e5851R568
 I added a modification to the test that avoids backpressuring during recovery 
(by applying backpressure only after the first successful checkpoint.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to