aljoscha opened a new pull request #14044:
URL: https://github.com/apache/flink/pull/14044


   ## What is the purpose of the change
   
   Before, we had both flink-connector-files and flink-connector-base as 
dependencies of flink-dist.
   
   This implies, that users should use the dependency like this:
   
   ```
   <dependency>
        <groupId>org.apache.flink</groupId>
        <artifactId>flink-connector-files</artifactId>
        <version>${project.version}</version>
        <scope>provided</scope>
   </dependency>
   ```
   
   which differs from other connectors where users don't need to specify 
`<scope>provided</scope>`.
   
   Also, flink-connector-files has flink-connector-base as a provided 
dependency, which means that examples that use this dependency will not run 
out-of-box in IntelliJ because transitive provided dependencies will not be 
considered.
   
   This change removes the dependencies from flink-dist and lets users use the 
File Connector like any other connector.
   
   I believe the initial motivation for "providing" the File Connector in 
flink-dist was to allow us to use the File Connector under the hood in methods 
such as StreamExecutionEnvironment.readFile(...). We could decide to deprecate 
and remove those methods or re-add the File Connector as an explicit 
(non-provided) dependency again in the future.
   
   ## Brief change log
   
   * only changes poms
   
   ## Verifying this change
   
   Covered by existing tests, that still pass.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): _maybe_
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to