tzulitai commented on a change in pull request #14034:
URL: https://github.com/apache/flink/pull/14034#discussion_r522678744
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/polling/PollingRecordPublisher.java
##########
@@ -46,6 +48,8 @@
private static final Logger LOG =
LoggerFactory.getLogger(PollingRecordPublisher.class);
+ private static final SequenceNumber TIMESTAMP_SENTINEL_SEQUENCE_NUMBER
= SENTINEL_AT_TIMESTAMP_SEQUENCE_NUM.get();
Review comment:
I don't think it's necessary to define a static final field here, as
enums already static and final by default.
i.e. it'll be equivalent to just use the enum
`SENTINEL_AT_TIMESTAMP_SEQUENCE_NUM` in the new changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
