[
https://issues.apache.org/jira/browse/FLINK-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231688#comment-17231688
]
Zhijiang commented on FLINK-16753:
----------------------------------
Thanks for the reminder [~NicoK].
I ever considered this concern while merging the commit. As it is not a bug
and this improvement seems not such sensitive on my side, then I only merged it
to master then.
But I am also fine with backporting it to the previous versions if you consider
it meaningful. :)
What is your opinion [~wind_ljy]? I am not quite sure the code path diff in the
early versions. So could you submit the separate PR for these versions if
finally decide to backport this improvement?
> Exception from AsyncCheckpointRunnable should be wrapped in
> CheckpointException
> -------------------------------------------------------------------------------
>
> Key: FLINK-16753
> URL: https://issues.apache.org/jira/browse/FLINK-16753
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.10.0, 1.11.0, 1.11.1
> Reporter: Jiayi Liao
> Assignee: Jiayi Liao
> Priority: Major
> Labels: pull-request-available, usability
> Fix For: 1.12.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If an exception is thrown from task's async checkpoint process, the
> checkpoint will be declined as expected, but the reason for declining
> checkpoint will be regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which
> gives a wrong message to users.
> I think we can simply replace
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> checkpointException);
> {code}
> with
>
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(),
> new CheckpointException(CheckpointFailureReason.EXCEPTION,
> checkpointException));
> {code}
> in {{AsyncCheckpointRunnable.handleExecutionException}}.
> cc [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
