dawidwys commented on a change in pull request #14078:
URL: https://github.com/apache/flink/pull/14078#discussion_r524367728
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskMailboxTestHarness.java
##########
@@ -143,12 +143,17 @@ public void waitForTaskCompletion() throws Exception {
}
}
- @Override
- public void close() throws Exception {
- streamTask.cancel();
-
+ public void finishProcessing() throws Exception {
Review comment:
Yes, I also found it problematic.
For a time I thought about not using this harness, but the deprecated
StreamTaskTestHarness instead which does simply call the invoke method, because
of the reason you described. However, because it does not let you process
elements step wise, you cannot e.g. issue `cancel` before it finishes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
