SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r525647349
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -669,13 +669,14 @@ public JobExecutionResult executeJobBlocking(JobGraph
job) throws JobExecutionEx
try {
jobResult = jobResultFuture.get();
} catch (ExecutionException e) {
- throw new JobExecutionException(job.getJobID(), "Could
not retrieve JobResult.", ExceptionUtils.stripExecutionException(e));
+ throw new JobExecutionException(job.getJobID(),
ApplicationStatus.UNKNOWN,
+ "Could not retrieve JobResult.",
ExceptionUtils.stripExecutionException(e));
}
try {
return
jobResult.toJobExecutionResult(Thread.currentThread().getContextClassLoader());
} catch (IOException | ClassNotFoundException e) {
- throw new JobExecutionException(job.getJobID(), e);
+ throw new JobExecutionException(job.getJobID(),
jobResult.getApplicationStatus(), e);
Review comment:
@kl0u IMO, I don't think this is misleading . The application status for
this exception case is SUCCESS, but the exception means the deserialization of
job result with an exception. We may add exception message to tell users that
the application is succeeded but the deserialization with an exception. What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
