[GitHub] [flink] aljoscha commented on a change in pull request #14122: [FLINK-20098] Don't add flink-connector-files to flink-dist, make dependencies explicit

[GitBox]

aljoscha commented on a change in pull request #14122:
URL: https://github.com/apache/flink/pull/14122#discussion_r526762762



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -31,6 +31,14 @@ under the License.
        <name>Flink : E2E Tests : Common Kafka</name>
 
        <dependencies>
+<!--           &lt;!&ndash; The SQL Client test uses a Table FileSource, which 
is not included in the normal table-->
+<!--           dependencies &ndash;&gt;-->
+<!--           <dependency>-->
+<!--                   <groupId>org.apache.flink</groupId>-->
+<!--                   <artifactId>flink-connector-files</artifactId>-->
+<!--                   <version>${project.version}</version>-->
+<!--           </dependency>-->
+

Review comment:
       Yes, I put this in because I thought I might have to uncomment it but I 
was 90% sure that it was not needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org