aljoscha commented on a change in pull request #14137:
URL: https://github.com/apache/flink/pull/14137#discussion_r526833438
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -284,6 +284,21 @@ public StreamExecutionEnvironment setParallelism(int
parallelism) {
return this;
}
+ /**
+ * Sets the runtime execution mode for the application (see {@link
RuntimeExecutionMode}).
+ * This is equivalent to setting the "execution.runtime-mode" in your
application's
+ * configuration file.
Review comment:
I think we should add a note here saying that this is not the
recommended way to do it. Users should keep the job itself free of
configuration and provided it via the commandline, to stay more flexible. What
do you think?
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkITCase.java
##########
@@ -235,8 +235,7 @@ public void writerAndGlobalCommitterExecuteInBatchMode()
throws Exception {
private StreamExecutionEnvironment buildStreamEnv() {
final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- final Configuration config = new Configuration();
Review comment:
Huh, this was not doing anything, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
