rkhachatryan commented on a change in pull request #14139:
URL: https://github.com/apache/flink/pull/14139#discussion_r527074012
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java
##########
@@ -162,10 +162,11 @@
"will timeout and checkpoint barrier
will start working as unaligned checkpoint.")
.build());
+ @Documentation.ExcludeFromDocumentation("Do not advertise this option
until rescaling of unaligned checkpoint is completed.")
public static final ConfigOption<Boolean> FORCE_UNALIGNED =
ConfigOptions.key("execution.checkpointing.unaligned.forced")
.booleanType()
- .defaultValue(false)
+ .defaultValue(true)
Review comment:
Why is this change needed?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -501,7 +501,7 @@ protected void beforeInvoke() throws Exception {
actionExecutor.runThrowing(() -> {
SequentialChannelStateReader reader =
getEnvironment().getTaskStateManager().getSequentialChannelStateReader();
- reader.readOutputData(getEnvironment().getAllWriters(),
!configuration.isGraphContainingLoops());
+ reader.readOutputData(getEnvironment().getAllWriters(),
false);
Review comment:
nit: add todo and mention the reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
