becketqin opened a new pull request #14142:
URL: https://github.com/apache/flink/pull/14142


   ## What is the purpose of the change
   The patch fixes the offsets commit in the following cases:
       1. The SplitFetcher has exited.
       2. The offsets to be committed is empty.
       3. The offsets commit for finished splits.
   
   ## Brief change log
   - Fix the SingleThreadFetcherManager to get the running fetchers correctly.
   - Change SourceReaderBase.onSplitFinished() to take a map of SplitId -> 
SplitState.
   - Fix Kafka offset commit to coorectly handle the following cases:
       1. The SplitFetcher has exited.
       2. The offsets to be committed is empty.
       3. The offsets commit for finished splits.
   
   ## Verifying this change
   The unit tests has been added to `KafkaSourceReaderTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes, the argument passed to 
`SourceReaderBase.onSplitFinish()` has changed)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to