[
https://issues.apache.org/jira/browse/FLINK-19940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235968#comment-17235968
]
Caizhi Weng edited comment on FLINK-19940 at 11/20/20, 8:07 AM:
----------------------------------------------------------------
[~roman_khachatryan] It's not truncated. It's just that the TableSourceScan
part does not appear. The task name in the detail tab on the right will not be
truncated, however the TableSourceScan part still doesn't appear. The #2
TableSourceScan indicates that its an input of the multiple input operator and
is included in the name of the MultipleInputOperator (we display all inputs of
the multiple input operator in its name), which is not that obvious for the
user to tell that there is a chained source. The whole string before "-> Calc"
is the name of the multiple input operator, which has nothing to do with source
chaining. We can just name the operator to "MultipleInput" and all the string
before "> Calc" will disappear. We name the operator like so just to expose the
inner structure of a multiple input operator.
Indeed, one can argue that source chaining is currently only implemented for
multiple input tasks, so it seems to be sufficient that chained sources are
hinted in the multiple input operators in table API. However source chaining is
related more to operator chaining rather than an operator in the table API. If
we implement source chaining for two-input operators in the future, or if the
users write a multiple input transformation themselves, then users will have no
way to tell whether there is a chained source or not. So I think we should
display the chained sources on the level of operator chains.
was (Author: tsreaper):
[~roman_khachatryan] It's not truncated. It's just that the TableSourceScan
part does not appear. The task name in the detail tab on the right will not be
truncated, however the TableSourceScan part still doesn't appear. The #2
TableSourceScan indicates that its an input of the multiple input operator and
is included in the name of the MultipleInputOperator (we display all inputs of
the multiple input operator in its name), which is not that obvious for the
user to tell that there is a chained source. The whole string before "-> Calc"
is the name of the multiple input operator, which has nothing to do with source
chaining. We can just name the operator to "MultipleInput" and all the string
before "> Calc" will disappear. We name the operator like so just to expose the
inner structure of a multiple input operator.
Indeed, one can argue that source chaining is currently only implemented for
multiple input tasks, so it seems to be sufficient that chained sources are
hinted in the multiple input operators in table API. However source chaining is
related more to operator chaining rather than an operator in the table API. If
we implement source chaining for two-input operators in the future, or if the
users write an multiple input transformation themselves, then users will have
no way to tell whether there is a chained source or not.
> Task names on web UI should change when an operator chain is chained with
> sources
> ---------------------------------------------------------------------------------
>
> Key: FLINK-19940
> URL: https://issues.apache.org/jira/browse/FLINK-19940
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend
> Reporter: Caizhi Weng
> Assignee: Roman Khachatryan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Attachments: multi-web-ui.png
>
>
> Currently task names on web UI doesn't change even if the operator chain is
> chained with sources. We should change its name to show that the sources are
> chained.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
