becketqin opened a new pull request #14158:
URL: https://github.com/apache/flink/pull/14158
…ourceCoordinator.
## What is the purpose of the change
Currently the when the `SourceCoordinator` fails the job by calling
`OperatorCoordinatorContext.failJob()`, it enqueues a task to the scheduler
thread. That means an `SourceCoordinator` instance may fail the job multiple
times, which is unnecessary and sometimes can cause infinite cascading job
failures.
This patch fixes the issue by only failing the job once in
`OperatorCoordinatorHolder` unless the `OperatorCoordinatorHolder` is reset to
checkpoint.
## Brief change log
- Add a failed flag in the OperatorCoordinator to avoid failing the job
multiple times.
## Verifying this change
The following unit test was added to verify the change.
`OperatorCoordinatorHolderTest.testFailingJobMultipleTimesNotCauseCascadingJobFailure`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
