StephanEwen commented on a change in pull request #14030:
URL: https://github.com/apache/flink/pull/14030#discussion_r528212362
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/ExecutorNotifier.java
##########
@@ -83,8 +83,8 @@ public ExecutorNotifier(ScheduledExecutorService
workerExecutor,
T result = callable.call();
executorToNotify.execute(() ->
handler.accept(result, null));
} catch (Throwable t) {
- LOG.error("Unexpected exception {}", t);
- handler.accept(null, t);
+ LOG.error("Unexpected exception", t);
Review comment:
Remove / update this log line.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/ExecutorNotifier.java
##########
@@ -133,7 +133,8 @@ public ExecutorNotifier(ScheduledExecutorService
workerExecutor,
T result = callable.call();
executorToNotify.execute(() ->
handler.accept(result, null));
} catch (Throwable t) {
- handler.accept(null, t);
+ LOG.error("Unexpected exception", t);
Review comment:
Remove / update the log line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
