StephanEwen commented on pull request #14030: URL: https://github.com/apache/flink/pull/14030#issuecomment-731599430
The fix is good. I would suggest to remove the indicated log statements. This is an exception happening in a utility function. The function lacks the context whether the exception really is a problem or not. Maybe the connector is just trying to do something and it is fine if it fails. But with the log statement there, we always have ERROR level messages coming out of the system on the master node, which looks super scary to users and folks running Flink. In general, I would avoid logging in utility calls. Logging that does not add information (the infamous "Unexpected Exception" log messages) are usually a good indication that this log statement should be removed. It "double reports" the exception, once to the log (without any context of whether it means something or not) and to the handler (which has the context whether the exception means something or not). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
