Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-193580086
Hi @danielblazevski, thanks for update and sorry for late reply. I tried to
test your implementation and have found few things to do before merging this.
First, It is about test cases. I think we should add a test case for KNN
with quad-tree rather than modifying a test case without quad-tree. Also we
need some test cases with non-executable configuration such as KNN with
quad-tree and non-compatible distance metric. A method to create a test case
with exceptions is described in scalatest documentation (**Intercepted
exceptions** section in http://www.scalatest.org/user_guide/using_assertions).
Second, package definitions of `QuadTree` and `QuadTreeSuite` are not
matched with directory structure.
Finally, I think we need to add more detail description with some
mathematical background of KNN and quad-tree (including link of your slides and
papers which you referred to) to the documentation. Also we need examples and
description of parameters with default value.
About rebasing, if you set `apache/flink` as remote `apache`, you can apply
commands I suggested with renaming `upstream` to `apache`. You don't need to
worry during rebasing. I also have copied branch of your `FLINK-1745` branch in
my local machine. If you have some problems with rebasing, I'll rebase on
`apache/master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
