NicoK commented on a change in pull request #13488:
URL: https://github.com/apache/flink/pull/13488#discussion_r528714370
##########
File path: docs/ops/state/savepoints.md
##########
@@ -110,14 +110,11 @@ For example with a `FsStateBackend` or
`RocksDBStateBackend`:
/savepoints/savepoint-:shortjobid-:savepointid/...
{% endhighlight %}
+After <a
href="https://issues.apache.org/jira/browse/FLINK-5763";>FLINK-5763</a>
savepoint is self-contained and relocatable now, you can move the file and
restore from any location.
Review comment:
```suggestion
Since Flink 1.11.0, savepoints are self-contained and relocatable (see <a
href="https://issues.apache.org/jira/browse/FLINK-5763";>FLINK-5763</a> for
details). You can move the file and restore from any location.
```
##########
File path: docs/ops/state/savepoints.md
##########
@@ -110,14 +110,11 @@ For example with a `FsStateBackend` or
`RocksDBStateBackend`:
/savepoints/savepoint-:shortjobid-:savepointid/...
{% endhighlight %}
+After <a
href="https://issues.apache.org/jira/browse/FLINK-5763";>FLINK-5763</a>
savepoint is self-contained and relocatable now, you can move the file and
restore from any location.
<div class="alert alert-info">
- <strong>Note:</strong>
-Although it looks as if the savepoints may be moved, it is currently not
possible due to absolute paths in the <code>_metadata</code> file.
-Please follow <a
href="https://issues.apache.org/jira/browse/FLINK-5778";>FLINK-5778</a> for
progress on lifting this restriction.
+<strong>Note: </strong>savepoint relocatable does not support taskowned
state(such as GenericWriteAhreadLog sink) and <a href="{% link
ops/filesystems/s3.md %}#entropy-injection-for-s3-file-systems">entropy
injection</a> currently.
Review comment:
```suggestion
<strong>Note: </strong>relocatable savepoints currently do not support
task-owned state(such as `GenericWriteAhreadLog` sink) or <a href="{% link
ops/filesystems/s3.md %}#entropy-injection-for-s3-file-systems">entropy
injection</a>.
```
##########
File path: docs/ops/state/savepoints.md
##########
@@ -110,14 +110,11 @@ For example with a `FsStateBackend` or
`RocksDBStateBackend`:
/savepoints/savepoint-:shortjobid-:savepointid/...
{% endhighlight %}
+After <a
href="https://issues.apache.org/jira/browse/FLINK-5763";>FLINK-5763</a>
savepoint is self-contained and relocatable now, you can move the file and
restore from any location.
<div class="alert alert-info">
- <strong>Note:</strong>
-Although it looks as if the savepoints may be moved, it is currently not
possible due to absolute paths in the <code>_metadata</code> file.
-Please follow <a
href="https://issues.apache.org/jira/browse/FLINK-5778";>FLINK-5778</a> for
progress on lifting this restriction.
+<strong>Note: </strong>savepoint relocatable does not support taskowned
state(such as GenericWriteAhreadLog sink) and <a href="{% link
ops/filesystems/s3.md %}#entropy-injection-for-s3-file-systems">entropy
injection</a> currently.
Review comment:
Can you actually add links to Jira tickets for these two points?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
