TsReaper commented on a change in pull request #14188:
URL: https://github.com/apache/flink/pull/14188#discussion_r529179392
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunction.java
##########
@@ -383,12 +383,10 @@ public void run() {
if (!version.equals(requestVersion) ||
requestOffset < offset) {
// invalid request
- if (LOG.isDebugEnabled()) {
- // this is normal for
the 1st request after the sink (re)starts, so we print debug log
- LOG.debug("Invalid
request. Received version = " + requestVersion +
- ", offset = " +
requestOffset + ", while expected version = "
- + version + ",
offset = " + offset);
- }
+ // this is normal for the 1st
request after the sink (re)starts
+ LOG.info("Invalid request.
Received version = " + requestVersion +
Review comment:
It won't flow the log file. This log only happens when the sink starts
or restarts.
This is a mechanism to inform the collect iterator that the sink has
restarted and is an expected behavior. So an info log is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
