[
https://issues.apache.org/jira/browse/FLINK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184922#comment-15184922
]
Timo Walther commented on FLINK-3574:
-------------------------------------
As I wrote previously: {{addSqlFunctionMethod}} just determines which types the
final Java method needs. You also don't specify Java methods with "numeric
type" but with a specialized type. If you take a look into {{SqlFunctions}} for
{{LOG10}} there are methods that take {{double}} and {{long}}. I would register
2 functions with the corresponding signature and as a fallback in
{{getCallGenerator}} I would iterate through all SqlOperators of same type and
check if {{TypeInfo.shouldAutoCastTo(TypeInfo)}}.
Regarding the replacement of OR etc. with CallGenerators. I also thought about
that when I implemented CallGenerators. We could do that later, but it's not
very important at the moment. However, we then need to ensure that the user
cannot override basic operators.
> Implement math functions for Table API
> --------------------------------------
>
> Key: FLINK-3574
> URL: https://issues.apache.org/jira/browse/FLINK-3574
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Timo Walther
> Assignee: Dawid Wysakowicz
>
> {code}
> MOD
> EXP
> POWER
> LN
> LOG10
> ABS
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
