zhuzhurk commented on a change in pull request #14163:
URL: https://github.com/apache/flink/pull/14163#discussion_r529221207
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -571,5 +573,9 @@ private TaskManagerOptions() {}
public static class ManagedMemoryConsumerNames {
Review comment:
It may be out of the scope of this task.
But I'm wondering whether we move this class into runtime module and just
use string in the config option?
`TaskManagerOptions` is a public interface. Users may also treat
`ManagedMemoryConsumerNames` as public interface which is actually unwanted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
