StephanEwen commented on a change in pull request #14181:
URL: https://github.com/apache/flink/pull/14181#discussion_r529272701
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -66,6 +76,43 @@ public void init() {
operatorChain);
}
+ @Override
+ protected void beforeInvoke() throws Exception {
Review comment:
I think just deleting init() can be dangerous. It means we create the
input processors much later in the setup sequence (after the `beforeInvoke()`
rather than early during that), which changes the setup can lead to surprises
down the way.
It may be that some part of the input sequence rely on the processors being
present.
The branch I referenced below has a way to create the reader earlier and
thus maintain the SteamTask's setup sequence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
