[
https://issues.apache.org/jira/browse/FLINK-20295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238125#comment-17238125
]
Stephan Ewen commented on FLINK-20295:
--------------------------------------
Thanks for debugging this. So this is a bug in the
{{DeserializationFormatAdapter}} implementation?
[~lzljs3620320] A thought on the {{DeserializationFormatAdapter}}
implementation:
- I think it makes sense to use a StreamRecordFormat here. Then you also
don't need to worry about batching.
- We can also use Java's {{BufferedReader(InputStreamReader())}} to parse the
lines. That is a bit less performant than out own fast parsing
DelimitedInputFormat, but it supports different charset encodings properly.
Currently, the DelimitedInputFormat fails on UTF-16 and some other charsets.
> File Source lost data when reading from directories created by
> FileSystemTableSink with JSON format
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-20295
> URL: https://issues.apache.org/jira/browse/FLINK-20295
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Table SQL / Ecosystem
> Reporter: Yun Gao
> Assignee: Jingsong Lee
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Attachments: compaction.tgz
>
>
> When testing the compaction functionality of the FileSystemTableSink, I found
> that when using json format, the produced directories could not be read
> correctly by the file source, namely only a part of records are read.
> By checking the produced directories, the number of the records in it is the
> same as expected, thus it seems to be the issue of the source side.
>
> The issue only exists for JSON format.
> The data is produced by
> [FileCompactionTest|https://github.com/gaoyunhaii/flink1.12test/blob/main/src/main/java/FileCompactionTest.java]
> and read by
> [FileCompactionCheckTest|https://github.com/gaoyunhaii/flink1.12test/blob/main/src/main/java/FileCompactionCheckTest.java]
> . An example directories tar file of 8000 records are also attached.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
