tillrohrmann commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r529612466
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() ==
ApplicationStatus.FAILED) {
Review comment:
I think if program throws a `JobCancellationException`, then we don't
set it in the `errorRef` variable. Hence, this test should not be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
