SteNicholas commented on pull request #14028:
URL: https://github.com/apache/flink/pull/14028#issuecomment-733035458


   > Thanks for creating this PR @SteNicholas. In general I like the 
unification of thrown exception. I had two questions:
   > 
   > 1. Is the `ProgramInvocationException` part of the public API of a 
`JobClient`?
   > 2. Can we remove the `JobExecutionException` from the runtime components 
(specifically the `ExecutionGraphBuilder`)?
   
   @tillrohrmann , thanks for your detailed review. My answer for above 
question you mentioned is as follows:
   1.ProgramInvocationException isn't the part of the public API of a 
JobClient. Even if it is, it is wrapped into CompletableFuture.
   2.Why the JobExecutionException is removed from the runtime components 
(specifically the ExecutionGraphBuilder)? What are the adverse effects of this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to