wuchong commented on a change in pull request #14165:
URL: https://github.com/apache/flink/pull/14165#discussion_r530138153
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/StreamPlanner.scala
##########
@@ -129,6 +129,13 @@ class StreamPlanner(
sb.append("== Physical Execution Plan ==")
sb.append(System.lineSeparator)
sb.append(executionPlan)
+
+ if (extraDetails.contains(ExplainDetail.JSON_EXECUTION_PLAN)) {
+ sb.append(System.lineSeparator)
+ sb.append("== Streaming Execution Plan ==")
+ sb.append(System.lineSeparator)
+ sb.append(streamGraph.getStreamingPlanAsJSON)
+ }
Review comment:
I have discussed with @godfreyhe . We think that we don't need to add a
new entry for the "Streaming Execution Plan". Because it is description the
same plan with "Physical Execution Plan", just in different format.
Thus, we suggest to replace the content of "Physical Execution Plan" using
the json string when `ExplainDetail` is in `JSON_EXECUTION_PLAN`.
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/StatementSet.java
##########
@@ -51,7 +51,7 @@
* all statements and Tables.
*
* @param extraDetails The extra explain details which the explain
result should include,
- * e.g. estimated cost, changelog mode for streaming
+ * e.g. estimated cost, changelog mode for
streaming, execution plan in json format
Review comment:
```suggestion
* e.g. estimated cost, changelog mode for
streaming, displaying execution plan in json format
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
