SteNicholas commented on a change in pull request #13983:
URL: https://github.com/apache/flink/pull/13983#discussion_r530142601



##########
File path: 
flink-python/src/main/java/org/apache/flink/api/common/python/PythonBridgeUtils.java
##########
@@ -266,6 +278,92 @@ private static Object getPickledBytesFromJavaObject(Object 
obj, LogicalType data
                }
        }
 
+       public static Object getPickledBytesFromJavaObject(Object obj, 
TypeInformation<?> dataType) throws IOException {

Review comment:
       @shuiqiangchen ,  `getPickledBytesFromJavaObject(obj, TypeInformation)` 
is different from `getPickledBytesFromJavaObject(obj, DataType)` for the 
difference between the type checker.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to