wuchong commented on a change in pull request #14085:
URL: https://github.com/apache/flink/pull/14085#discussion_r530309638
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RowDataToAvroConverters.java
##########
@@ -67,13 +67,28 @@ public static RowDataToAvroConverter
createConverter(LogicalType type) {
final RowDataToAvroConverter converter;
switch (type.getTypeRoot()) {
case NULL:
- converter = (schema, object) -> null;
+ converter = new RowDataToAvroConverter() {
Review comment:
Could we add `@SuppressWarnings("Convert2Lambda")` annotation to the
method? This can avoid warning in the IDEA. Besides, it would be better to add
`serialVersionUID` to the `RowDataToAvroConverter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
