AHeise commented on a change in pull request #14218:
URL: https://github.com/apache/flink/pull/14218#discussion_r530356997
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/SingleCheckpointBarrierHandler.java
##########
@@ -158,14 +163,16 @@ public void processBarrierAnnouncement(
@Override
public void processCancellationBarrier(CancelCheckpointMarker
cancelBarrier) throws IOException {
final long cancelledId = cancelBarrier.getCheckpointId();
- if (currentCheckpointId > cancelledId || (currentCheckpointId
== cancelledId && numBarriersReceived == 0)) {
- return;
+ if (cancelledId >= currentCheckpointId && (cancelledId >
currentCheckpointId || numBarriersReceived > 0)) {
Review comment:
It's correct but it might be easier to do
```
cancelledId > currentCheckpointId || (currentCheckpointId == cancelledId &&
numBarriersReceived > 0)
```
So either it's a future checkpoint, or it's the current checkpoint and not
yet canceled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
