Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1575#issuecomment-194236417
Hey @s1ck,
thanks a lot for the thorough review! I will address your comments in the
following days. The PR is quite old and needs a rebase, too.
For future reviews, keep in mind that it might be better to leave comments
on the file diff of the PR instead of commenting on each individual commit.
This way replying is easier, comments appear at one place, and the reviewer has
the final changed view instead of the partial changes of each commit :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
