twalthr commented on a change in pull request #14103:
URL: https://github.com/apache/flink/pull/14103#discussion_r530846446
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
##########
@@ -1122,12 +1125,14 @@ void registerDataSink(DataSink<?> sink) {
}
/**
- * Gets a default job name, based on the timestamp when this method is
invoked.
+ * Gets the job name. If user defined job name is not found in the
configuration,
+ * the default name based on the timestamp when this method is invoked
will return.
*
- * @return A default job name.
+ * @return A job name.
*/
- private static String getDefaultName() {
- return "Flink Java Job at " + Calendar.getInstance().getTime();
+ @VisibleForTesting
Review comment:
This method must not be public and thus part of the API. You can call
`createProgramPlan().getJobName` for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
