dianfu commented on a change in pull request #14232:
URL: https://github.com/apache/flink/pull/14232#discussion_r530977090
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java
##########
@@ -375,4 +379,10 @@ static Process launchPy4jPythonClient(
// start the python process.
return PythonEnvUtils.startPythonProcess(pythonEnv, commands,
redirectToPipe);
}
+
+ public static void setPythonException(Exception pythonException) {
Review comment:
```suggestion
public static void setPythonException(Throwable pythonException) {
```
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java
##########
@@ -106,9 +105,11 @@ public static void main(String[] args) throws
ExecutionException, InterruptedExc
} catch (Throwable e) {
LOG.error("Run python process failed", e);
- // throw ProgramAbortException if the caller is
interested in the program plan,
Review comment:
the comments could be kept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
