[ 
https://issues.apache.org/jira/browse/FLINK-20378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-20378.
---------------------------
    Resolution: Not A Problem

Currently, the framework doesn't support TIMESTAMP WITH LOCAL TIME ZONE type as 
rowtime (assign watermark). In order to support this type, we should add time 
zone offset into the value when calculating windows. If we remove this check, 
the window result will be wrong with a deviation of time zone offset.

> Watermark generation check TIMESTAMP_WITHOUT_TIME_ZONE
> ------------------------------------------------------
>
>                 Key: FLINK-20378
>                 URL: https://issues.apache.org/jira/browse/FLINK-20378
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.11.1
>            Reporter: wxmimperio
>            Priority: Major
>
>  
>  
> {code:java}
>  def generateWatermarkGenerator(
>       config: TableConfig,
>       inputType: RowType,
>       watermarkExpr: RexNode): GeneratedWatermarkGenerator = {
>     // validation
>     val watermarkOutputType = 
> FlinkTypeFactory.toLogicalType(watermarkExpr.getType)
>     if (watermarkOutputType.getTypeRoot != 
> LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE) {
>       throw new CodeGenException(
>         "WatermarkGenerator only accepts output data type of TIMESTAMP," +
>           " but is " + watermarkOutputType)
>     }
> {code}
>  
> Why does watermark generation need to be detected as 
> TIMESTAMP_WITHOUT_TIME_ZONE?
> If I remove this check, what effect will it have on the watermark?
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to