twalthr commented on a change in pull request #14174:
URL: https://github.com/apache/flink/pull/14174#discussion_r531136186



##########
File path: 
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
##########
@@ -300,14 +300,14 @@ protected void setFieldsGeneric(boolean[] includedMask, 
Class<?>[] fieldTypes) {
        // 
--------------------------------------------------------------------------------------------
        //  Runtime methods
        // 
--------------------------------------------------------------------------------------------
-       
+
        @Override
-       public void open(FileInputSplit split) throws IOException {
-               super.open(split);
+       public void initializeSplit(FileInputSplit split, Long offset) throws 
IOException {
+               super.initializeSplit(split, offset);
 
                // instantiate the parsers
                FieldParser<?>[] parsers = new 
FieldParser<?>[fieldTypes.length];

Review comment:
       Sorry, I was too quick with this comment. I didn't check whether the 
parsers are stateful. In this case, we need to recreate them during `reopen()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to