Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1776#issuecomment-194786495
  
    Thanks @gallenvara for opening the PR. Looks mostly good but the tests need 
to be improved, IMO.
    
    It would also be good to extend the `DataDistribution` interface by adding 
a method `TypeInformation[] getKeyTypes()`. This will allow us to validate the 
key types of the `DataDistribution` and the specified keys in the 
`PartitionOperator`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to