rmetzger commented on a change in pull request #14251:
URL: https://github.com/apache/flink/pull/14251#discussion_r531639026
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -932,7 +932,7 @@ private void resetAndStartScheduler() throws Exception {
);
}
- schedulerAssignedFuture.thenRun(this::startScheduling);
+
FutureUtils.assertNoException(schedulerAssignedFuture.thenRun(this::startScheduling));
Review comment:
Out of curiosity: What speaks against additionally changing
`SchedulerBase.startAllOperatorCoordinators()` as follows:
```
private void startAllOperatorCoordinators() {
final Collection<OperatorCoordinatorHolder> coordinators =
getAllCoordinators();
try {
for (OperatorCoordinatorHolder coordinator :
coordinators) {
coordinator.start();
}
}
catch (Throwable t) {
ExceptionUtils.rethrowIfFatalErrorOrOOM(t);
coordinators.forEach(IOUtils::closeQuietly);
failJob(new FlinkRuntimeException("Failed to start the
operator coordinators", t)); // <-- change here
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
