[ 
https://issues.apache.org/jira/browse/FLINK-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189374#comment-15189374
 ] 

ASF GitHub Bot commented on FLINK-3529:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1729#discussion_r55688207
  
    --- Diff: PULL_REQUEST_TEMPLATE.md ---
    @@ -0,0 +1,18 @@
    +Thanks for contributing to Apache Flink. Before you open your pull 
request, please take the following check list into consideration.
    +If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    +In addition to going through the list, please provide a meaningful 
description of your changes.
    +
    +- [ ] General
    +  - The pull request references the related JIRA issue
    +  - The pull request addresses only one issue
    +  - Each commit in the PR has a meaningful commit message
    +
    +- [ ] Documentation
    +  - Documentation has been added for new functionality
    +  - Old documentation affected by the pull request has been updated
    +  - JavaDoc for public methods has been added
    +
    +- [ ] Tests & Build
    +  - Functionality added by the pull request is covered by tests
    +  - `mvn clean verify` has been executed successfully locally
    +  - or a Travis build has passed
    --- End diff --
    
    Could you combine the last two in a single bullet point?


> Add pull request template
> -------------------------
>
>                 Key: FLINK-3529
>                 URL: https://issues.apache.org/jira/browse/FLINK-3529
>             Project: Flink
>          Issue Type: Task
>          Components: other
>            Reporter: Martin Liesenberg
>            Assignee: Martin Liesenberg
>            Priority: Minor
>
> Add a template for pull requests, checking if prerequisites of opening a PR 
> have been fulfilled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to